----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121333/#review71278 -----------------------------------------------------------
Ship it! Looks good to me, when I did the port it used to work, I'm unsure where we went wrong. Maybe it would be possible to get a unit test? - Aleix Pol Gonzalez On Dec. 2, 2014, 10:10 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121333/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 10:10 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > When the look and feel lockscreen theme failed to load for whatever reason, > it is supposed to fall back to a built-in theme to not lock the user out of > the system. > > The fallbak did not work and crashed with an invalid package access, trapping > you in an endless kscreenlocker_greet reboot loop. This is most likely a > porting oversight since the default lockscreen theme, as indicated by the > constant, is no longer present or used. > > > Diffs > ----- > > ksmserver/screenlocker/greeter/greeterapp.cpp d3f9f28 > > Diff: https://git.reviewboard.kde.org/r/121333/diff/ > > > Testing > ------- > > Messed around in the look and feel qml file, got fallback. > > The fallback theme is quite broken, though, with the switch user button not > working, the dialog background missing as well as the wallpaper but at leas > it now works again. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
