> On Dec. 11, 2014, 1:18 p.m., Martin Klapetek wrote:
> > Btw. do you have an actual bug where this can be seen/tested? Good spot 
> > otherwise!

I had seen something which I did not understand in the past: owncloud sync 
client was for a short time Qt 5.3 based and the icon was just broken and I 
didn't understand it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121439/#review71793
-----------------------------------------------------------


On Dec. 11, 2014, 9:26 a.m., Dmitry Shachnev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121439/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2014, 9:26 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Documentation of KStatusNotifierItem::showMessage() says:
> 
> const QString &icon | icon to be shown to the user
> 
> So we need name of the icon here, not name of the theme.
> 
> 
> Diffs
> -----
> 
>   src/platformtheme/kdeplatformsystemtrayicon.cpp 51f31ad 
> 
> Diff: https://git.reviewboard.kde.org/r/121439/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Shachnev
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to