----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121453/#review71832 -----------------------------------------------------------
Ship it! Even worse when seconds are on... - Martin Klapetek On Dec. 11, 2014, 10:30 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121453/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 10:30 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > cache QTimeZone for the lifespan of the TimeSource don't recreate every minute > > QTimeZone::systemTimeZoneId() will open /etc/localtime every single time it > is called. > > We are calling this in ::updateTime which happens every single minute. > > > Diffs > ----- > > dataengines/time/timesource.h 5ee1ef6 > dataengines/time/timesource.cpp 934ed49 > > Diff: https://git.reviewboard.kde.org/r/121453/diff/ > > > Testing > ------- > > Ran strace -e open plasmashell without crying > > Selected a few zones and mouse-wheeled between them. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel