On Dec. 13, 2014, 4:33 p.m., Andrea Scarpino wrote: > > I know this has already been submitted thanks to Bhushan, but I really have > > to add a -2 here. > > > > This code has clearly not been ported at all! > > > > Did you even test this before you pushed it, or is this a case of "It > > builds, ship it"? > > The fact that others had to tell you that it doesn't build suggests that > > you didn't even try building it. > > Andrea Scarpino wrote: > Hi Fredrik, > the old review got 2 "Ship It" in past and then I rebased this to merge > it. > > I did it with the help on Bhushan via IRC (if you read, please confirm > :-), without building it myself. > > Should I revert it?
No, but CursorNotificationHandler needs to be ported correctly. It should inherit QAbstractNativeEventFilter instead of QWidget, and reimplement nativeEventFilter() instead of x11Event(). - Fredrik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121473/#review71925 ----------------------------------------------------------- On Dec. 13, 2014, 12:50 p.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121473/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2014, 12:50 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Rebased https://git.reviewboard.kde.org/r/114260/ > > > Diffs > ----- > > dataengines/mouse/mouseengine.h d55565dc3875b794dce14054d9a8b77cef9b2347 > dataengines/mouse/mouseengine.cpp f1c898150e04b44dad1c8a0fc757c1ffdf94941b > dataengines/CMakeLists.txt cae926b550cdd69aa0194e19bc4818c597e174c0 > dataengines/mouse/CMakeLists.txt 29cab878bd1fb514d7ac025134fbfb58a5a1376e > dataengines/mouse/cursornotificationhandler.h > 3b571f8f5ffe6db4efeef7827acf003911bcd5dc > dataengines/mouse/cursornotificationhandler.cpp > cf1c3fbe91a9afee5090d167dd6cd51637df04d4 > > Diff: https://git.reviewboard.kde.org/r/121473/diff/ > > > Testing > ------- > > > Thanks, > > Andrea Scarpino > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
