----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121294/#review72046 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Dec. 4, 2014, 9:16 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121294/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 9:16 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Do not bind the image's sourceSize to the root item's size since that will > reload the image whenever the size changes. This is especially noticeable in > plasmoidviewer where resizing the window causes the background to go black > momentarily. > > This makes it wait 1s before actually changing the source size, preventing > continuous reloading when resizing the window but should also improve > resolution changes. Also, it waits for the size to become non-zero before > loading the image. Setting a sourceSize of (0,0) is equivalent to not setting > it at all, causing it to load the full image, just to reload it in the proper > size afterwards. > > There's still an issue that the view starts up with a size of 1024x768, loads > the wallpaper, and then resizes itself to the screen geometry, causing a > delayed reload of the image which was previously not visible but together > with me waiting for the size to become available you can see that on > plasmashell startup, when using eg. the tiled fill mode. > > Unrelated: > - Move the swap image stuff into a separate function > - Use my animate binding trick for fillMode change too, now these are > lag-free also > > > Diffs > ----- > > wallpapers/image/imagepackage/contents/ui/main.qml 1f11795 > > Diff: https://git.reviewboard.kde.org/r/121294/diff/ > > > Testing > ------- > > Plasmoidviewer is much prettier to use now, no flickering, Plasmashell > startup is a bit more nasty imho (especially when using a wallpaper > background color) but should be concealed by ksplash. Switching between > wallpapers and fillmodes is smooth, it fades from black when changing a > wallpaper and fillmode at the same time but afaics that has been the case > previously, too. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
