----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121533/#review72064 -----------------------------------------------------------
shell/shellcorona.cpp <https://git.reviewboard.kde.org/r/121533/#comment50252> too complex: there's a overload taking a QKeySequence: KGlobalAccel::self()->setGlobalShortcut(activityAction, Qt::META + Qt::Key_Q); shell/shellcorona.cpp <https://git.reviewboard.kde.org/r/121533/#comment50253> *cough* shell/shellcorona.cpp <https://git.reviewboard.kde.org/r/121533/#comment50255> nitpick: const shell/shellcorona.cpp <https://git.reviewboard.kde.org/r/121533/#comment50254> nitpick: coding style shell/shellcorona.cpp <https://git.reviewboard.kde.org/r/121533/#comment50257> nitpick: const - Martin Gräßlin On Dec. 15, 2014, 4:23 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121533/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 4:23 p.m.) > > > Review request for Plasma. > > > Bugs: 341856 > https://bugs.kde.org/show_bug.cgi?id=341856 > > > Repository: plasma-workspace > > > Description > ------- > > In Plasma 4 plasma-desktop registered global shortcuts for activities > management > > Add those actions back > > > Diffs > ----- > > shell/shellcorona.h 7c25cd4 > shell/shellcorona.cpp c416217 > > Diff: https://git.reviewboard.kde.org/r/121533/diff/ > > > Testing > ------- > > all shortcuts, Meta + Q, Meta + Tab and Meta + Shift + Tab works fine > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
