----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121806/#review73024 -----------------------------------------------------------
Adding a method to one class (DesktopView) to manipulate another an instance of another class (Dialog) whilst using nothing from DesktopView to me seems like poor API. I'd consider Q_INVOKABLE forceActiveFocus() on Plasma::Dialog - David Edmundson On Jan. 3, 2015, 2:35 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121806/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2015, 2:35 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This way the Desktop containment can eventually force the widget explorer and > activity explorer active so they always accept keyboard input. Currently > often you end up with a visibly focussed (ie. blinking cursor) panel but you > cannot enter anything. > It is in the desktopview and not in some global import to minimize misuse > outside the workspace scope. > > > Diffs > ----- > > shell/desktopview.h ea9e555 > shell/desktopview.cpp bbe16f2 > > Diff: https://git.reviewboard.kde.org/r/121806/diff/ > > > Testing > ------- > > In conjunction with a patch plasma-desktop, pressing Meta+Q at any given time > causes the activity manager to open and it accepts keyboard events, entering > a new activity name, etc works. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
