> On Jan. 20, 2015, 3:46 nachm., Marco Martin wrote: > > Ship It! > > Dmitry Shachnev wrote: > I will need someone to push it for me, but first I want to get the > meteo-qt developer to test it (I have sent him a link), wait until that > please.
Ok, I tested it myself on another machine, and the fix work there as well (after applying the needed Qt change). Please go ahead and submit this. - Dmitry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122171/#review74397 ----------------------------------------------------------- On Jan. 20, 2015, 3:40 nachm., Dmitry Shachnev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122171/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 3:40 nachm.) > > > Review request for Plasma. > > > Repository: frameworkintegration > > > Description > ------- > > Implement SystemTrayMenuItem::setMenu() correctly. > > We need to actually set the action menu, not just store it somewhere, to make > submenus in tray icons working. > > > Diffs > ----- > > src/platformtheme/kdeplatformsystemtrayicon.h 3c1bbf7 > src/platformtheme/kdeplatformsystemtrayicon.cpp d3a1d4f > > Diff: https://git.reviewboard.kde.org/r/122171/diff/ > > > Testing > ------- > > Tested this app: https://github.com/dglent/meteo-qt > > > Thanks, > > Dmitry Shachnev > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
