----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122200/ -----------------------------------------------------------
(Updated Jan. 23, 2015, 1:14 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Kai Uwe Broulik. Repository: kdeclarative Description ------- It is currently not possible to use Q_INVOKABLE that takes Q_ENUM/Q_FLAGS as a parameter that is defined in a different class. This is mentioned in the docs and there's also a bug report here - https://bugreports.qt.io/browse/QTBUG-20639 If the default parameter is removed from the formatDuration, Plasma will complain with "Error: Unknown method parameter type KFormat::DurationFormatOptions". Until that one is fixed, we can either take an integer and cast it to the flags or redeclare the enum from KFormats locally, but that's just not good. Diffs ----- src/qmlcontrols/kcoreaddons/formats.h 59537bf src/qmlcontrols/kcoreaddons/formats.cpp 256778f Diff: https://git.reviewboard.kde.org/r/122200/diff/ Testing ------- KFormat now properly formats the remaining time based on the passed flags. Thanks, Martin Klapetek
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
