> On Jan. 26, 2015, 2:38 p.m., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma. Applications in future > will need to open KCMs too. > If we put it in Plasma in one year we'll end up with this anyway and we > end up maintaining a weird system used only by us. > > Also from a discussion on IRC you'll end up guessing the name to put in > the UI. This will lead to blocking developers from being able to do the right > thing by trying to be too clever.
My suggestion is to have both this can be used by applets if they don't like solution provided by plasma-framework OR optionally turn this into simple processrunner, there are use cases for both methods - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74750 ----------------------------------------------------------- On Jan. 25, 2015, 5:24 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122239/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2015, 5:24 a.m.) > > > Review request for Plasma. > > > Repository: kdeclarative > > > Description > ------- > > Since there are already like 10 copies of the ProcessRunner for all kinds of > plasmoids wanting to open a KCM, this adds a KCMShell.open("foo") and > KCMShell.open(["foo", "bar", "baz"]) singleton. > > > Diffs > ----- > > src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 65e28ff > src/qmlcontrols/kquickcontrolsaddons/kcmshell.h PRE-CREATION > src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp PRE-CREATION > src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 289f1ed > > Diff: https://git.reviewboard.kde.org/r/122239/diff/ > > > Testing > ------- > > Works. Dunno if the name causes clashes or this is the right place to put it. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
