> On Feb. 4, 2015, 1:49 p.m., David Edmundson wrote: > > applets/systemmonitor/common/contents/ui/Applet.qml, line 153 > > <https://git.reviewboard.kde.org/r/122420/diff/2/?file=346883#file346883line153> > > > > I'm lost on something. > > > > Why do we have a component singleValuePlotter and also SinglePlotter.qml > > > > same for twoValuesPlotter and DoublePlotter.qml > > > > They seem almost the same yet not quite?
ah, right, those two inline components are old dead code, removed it > On Feb. 4, 2015, 1:49 p.m., David Edmundson wrote: > > applets/systemmonitor/common/contents/ui/Applet.qml, line 164 > > <https://git.reviewboard.kde.org/r/122420/diff/2/?file=346883#file346883line164> > > > > what colour does the Plotter background default to? > > > > There's potential for a white on white situation here if we hardcode > > one value and take one from a theme. the background of the plotter is transparent, so goes over the applet background. that means highlightcolor over backgroundcolor, that is as guaranteed as possible to not be broken i guess > On Feb. 4, 2015, 1:49 p.m., David Edmundson wrote: > > klipper/org.kde.plasma.clipboard.operations, line 16 > > <https://git.reviewboard.kde.org/r/122420/diff/2/?file=346917#file346917line16> > > > > this is probably just reviewboard being stupid, but make sure this is > > in a separate commit yeah, comes from a simple diff between the branch and master - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/#review75383 ----------------------------------------------------------- On Feb. 4, 2015, 12:26 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122420/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 12:26 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > this refactors the net systemmonitor plasmoid (hopefully fixing some of the > bugs people had with it) > and brings back some other modules: > * cpu usage > * disk i/o activity > * memory usage > All applets share most of their stuff having as little duplication as possible > > > Diffs > ----- > > applets/CMakeLists.txt 25d774e > applets/systemmonitor/CMakeLists.txt PRE-CREATION > applets/systemmonitor/Messages.sh 2382ed6 > applets/systemmonitor/common/contents/config/main.xml PRE-CREATION > applets/systemmonitor/common/contents/ui/Applet.qml PRE-CREATION > applets/systemmonitor/common/contents/ui/ConfigGeneral.qml PRE-CREATION > applets/systemmonitor/common/contents/ui/DoublePlotter.qml PRE-CREATION > applets/systemmonitor/common/contents/ui/SinglePlotter.qml PRE-CREATION > applets/systemmonitor/contents/config/config.qml 11944e5 > applets/systemmonitor/contents/config/main.xml 57a30cb > applets/systemmonitor/contents/ui/configGeneral.qml 164e890 > applets/systemmonitor/contents/ui/net.qml 20e1d47 > applets/systemmonitor/cpu/Messages.sh PRE-CREATION > applets/systemmonitor/cpu/contents/config/config.qml PRE-CREATION > applets/systemmonitor/cpu/contents/ui/cpu.qml PRE-CREATION > applets/systemmonitor/cpu/contents/ui/cpuConfig.qml PRE-CREATION > applets/systemmonitor/cpu/metadata.desktop PRE-CREATION > applets/systemmonitor/diskactivity/Messages.sh PRE-CREATION > applets/systemmonitor/diskactivity/contents/config/config.qml PRE-CREATION > applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml > PRE-CREATION > applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml > PRE-CREATION > applets/systemmonitor/diskactivity/metadata.desktop PRE-CREATION > applets/systemmonitor/diskusage/Messages.sh PRE-CREATION > applets/systemmonitor/diskusage/contents/config/config.qml PRE-CREATION > applets/systemmonitor/diskusage/contents/ui/diskusage.qml PRE-CREATION > applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml > PRE-CREATION > applets/systemmonitor/diskusage/metadata.desktop PRE-CREATION > applets/systemmonitor/memory/Messages.sh PRE-CREATION > applets/systemmonitor/memory/contents/config/config.qml PRE-CREATION > applets/systemmonitor/memory/contents/ui/memory.qml PRE-CREATION > applets/systemmonitor/memory/contents/ui/memoryConfig.qml PRE-CREATION > applets/systemmonitor/memory/metadata.desktop PRE-CREATION > applets/systemmonitor/metadata.desktop 00965ab > applets/systemmonitor/net/Messages.sh PRE-CREATION > applets/systemmonitor/net/contents/config/config.qml PRE-CREATION > applets/systemmonitor/net/contents/ui/net.qml PRE-CREATION > applets/systemmonitor/net/contents/ui/netConfig.qml PRE-CREATION > applets/systemmonitor/net/metadata.desktop PRE-CREATION > klipper/org.kde.plasma.clipboard.operations 5e9f71a > > Diff: https://git.reviewboard.kde.org/r/122420/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
