> On Feb. 4, 2015, 2:16 p.m., Kai Uwe Broulik wrote:
> > applets/clipboard/contents/ui/BarcodePage.qml, line 104
> > <https://git.reviewboard.kde.org/r/122402/diff/6/?file=346839#file346839line104>
> >
> > running: visible ?
This is already done in the style
RotationAnimator on rotation {
running: control.running && indicatorItem.visible &&
indicatorItem.opacity > 0;
}
by you IIRC...
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122402/#review75407
-----------------------------------------------------------
On Feb. 4, 2015, 12:21 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122402/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 12:21 p.m.)
>
>
> Review request for Plasma and Sune Vuorela.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> When clicking the barcode button, the view is changed to just show
> the barcode instead of opening a dialog. By default a QR Code is
> displayed.
>
> A tool button is added which allows to change the barcode type, with
> the following barcodes being supported:
> * QR
> * Data Matrix
> * Code 39
> * Code 93
>
>
> Diffs
> -----
>
> applets/clipboard/contents/ui/BarcodePage.qml PRE-CREATION
> applets/clipboard/contents/ui/ClipboardPage.qml PRE-CREATION
> applets/clipboard/contents/ui/clipboard.qml
> 23cabadd2fec73b2c5343439b821e3d819223eeb
> klipper/CMakeLists.txt a08f062480b15f32f049e2d0d0e311dbe2964c02
> klipper/clipboardjob.cpp ad6b6358d0d9bfce25045f997f017e262d6e7f53
> klipper/org.kde.plasma.clipboard.operations
> 5e9f71ac1888fbce90f8c6e55decaf8e737bea0d
>
> Diff: https://git.reviewboard.kde.org/r/122402/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> QR Code
>
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/ba143497-eb97-4389-93ca-752e309386c1__missing-tasks-applet1.png
> data Matrix
>
> https://git.reviewboard.kde.org/media/uploaded/files/2015/02/03/5dde29fb-7044-453a-9544-f8f6b9ba5cef__missing-tasks-applet1.png
>
>
> Thanks,
>
> Martin Gräßlin
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
