On Feb. 9, 2015, 1:21 vorm., Kai Uwe Broulik wrote: > > I'd advice against the new C++ functions. You can use setDisplayDate (even > > in QML with the displayedDate property) to accomplish the exact same thing > > and it keeps the C++ API clean. > > If you really want to have the "helper functions" on the C++ side then you > > should call setDisplayDate(...) within those helper functions. > > > > But i like your change from a visual perspective :) I actually think John > > Layt had this on his wish lish for the calendar! > > Also, did you notice your bottom border in the month view is missing? It's > > like that in plasma 5.2 as well.
I added them because the others were there and I didn't figure out how to work with displayedDate, given JS Date is super horrible to work with but I'll take a look. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75649 ----------------------------------------------------------- On Feb. 8, 2015, 8:52 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122488/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2015, 8:52 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-framework > > > Description > ------- > > This improves the calendar navigation by providing a "Year overview" showing > all 12 months in a grid, and a "Decade overview" showing the current decade > in a grid. > > A lot of code has just been moved around. The overviews use a QML ListModel > owing to laziness. > > See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that > mouse click effect!) > > > Diffs > ----- > > src/declarativeimports/calendar/calendar.cpp a766acb > src/declarativeimports/calendar/daydata.h 39ac086 > src/declarativeimports/calendar/daysmodel.h ec88837 > src/declarativeimports/calendar/daysmodel.cpp 1a6f454 > src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e > src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e > src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db > src/declarativeimports/calendar/calendar.h ea20bf5 > > Diff: https://git.reviewboard.kde.org/r/122488/diff/ > > > Testing > ------- > > I changed the selection to be persistent during navigation; other than that, > should work as before, with the new overviews. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel