> On Feb. 10, 2015, 9:01 a.m., Mark Gaiser wrote: > > I'm not quite sure if a user wants to see a warning message at all. > > When i use my notebook in a dark environment i usually put the brightness > > all the way down (depending on the notebook). > > Kai Uwe Broulik wrote: > As I stated above, "all the way down" can mean "completely off", which I > wouldn't expect as a user. I've never seen any other device that does that, > apart from some black and white seven-segment display calculators. > > Mark Gaiser wrote: > Then it's device specific even! > - My notebook: all the way down = still visible > - My macbook: all the way down = off > > Can you detect that? > > You message does make sense if the lowest step = off. It doesn't if the > lowest step is still on. > > Martin Klapetek wrote: > Note that this is only for when you are dragging it by mouse - if you > drag it all the way down and your screen goes black, there's no way to > recover if your keys don't work. If your keys work and stuff, you probably > never use the slider, so this for a minority of users. It's the same reason > we ask confirmation when deleting a file.
Wait wait wait wait... Could it be that we've come up with an overly complex solution to a rather simple problem? Actually, those devices which turn the backlight off at 0% brightness are the only ones doing it _right_. I always found it very weird when my screen brightness OSD said "0%" but I could still see things. 0% brightness means zero brightness means _dark_. So why should the user even be able to set the brightness to 0% anyway? Since turning off the backlight without turning off the screen doesn't make sense practically, there just should be no way for the user to set the brightness to 0%, period. So let the slider start at 1% and don't allow the brightness to go zero neither via power management nor via brightness keys. That solves two problems: Accidentally setting to zero _and_ that semantic bullshit of "0% brightness but I can still see stuff". - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122505/#review75756 ----------------------------------------------------------- On Feb. 9, 2015, 10:25 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122505/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 10:25 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > ------- > > Some graphics drivers, notably Intel, turn off the backlight completely when > brightness reached zero, which is also in the spec (0 = off, 1 = very dim) > but imho that's unexpected. To prevent the user from accidentally turnign the > screen off, especially when keyboard brightness controls don't work, which > sadly still happens quite often, the slider breaks free from the user's drag > (by becoming disable for two (perhaps 1 is enough?) seconds, so we also catch > the mouse wheel case) and displays a warning (which stays there until screen > brightness is dialed up again). > > > Diffs > ----- > > applets/batterymonitor/package/contents/ui/BrightnessItem.qml 546ab58 > applets/batterymonitor/package/contents/ui/PopupDialog.qml a2acf31 > > Diff: https://git.reviewboard.kde.org/r/122505/diff/ > > > Testing > ------- > > Works pretty well, I just realized I forgot the mousewheel-on-trayicon case. > Also, I'm open to wording suggestions since it sounds more like "we suck, > sorry about that". (Note in the screenshot I used the mouse wheel, hence the > displayed 4% rather than 5) > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/02/09/8b585088-e33e-4862-9c46-207d06f566f1__dimwarning.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
