> On Feb. 11, 2015, 2:25 p.m., Sebastian Kügler wrote: > > components/shellprivate/widgetexplorer/widgetexplorer.cpp, line 33 > > <https://git.reviewboard.kde.org/r/122524/diff/1/?file=348257#file348257line33> > > > > Is this still needed?
right, widgetsMenuActions() is still not really ported, still have to finish that > On Feb. 11, 2015, 2:25 p.m., Sebastian Kügler wrote: > > shell/scripting/scriptengine.cpp, line 42 > > <https://git.reviewboard.kde.org/r/122524/diff/1/?file=348299#file348299line42> > > > > This include can go away, I suppose. there as well is still using pluginloader::listcontainmentsoftype that's fine - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122524/#review75858 ----------------------------------------------------------- On Feb. 11, 2015, 1:44 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122524/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 1:44 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > this is the branch mart/KPackage. > it ports away the various stuff (shell, krunner, screenlocker.. ) using > Plasma::Package to KPackage directly > the widget explorer/alternatives is also ported away from sycoca, using the > new kpackage cache mechanism to query for applets > > > Diffs > ----- > > shell/packageplugins/qmlWallpaper/CMakeLists.txt cc6ece1 > shell/packageplugins/qmlWallpaper/plasma-packagestructure-wallpaper.desktop > 48a6d52 > shell/packageplugins/layouttemplate/layouttemplate.h a8a1f52 > shell/packageplugins/layouttemplate/layouttemplate.cpp 50beeb2 > > shell/packageplugins/layouttemplate/plasma-packagestructure-layouttemplate.desktop > f870e0d > components/shellprivate/interactiveconsole/interactiveconsole.cpp 662e3de > components/shellprivate/widgetexplorer/openwidgetassistant.cpp ed1d0e3 > components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 42422d1 > components/shellprivate/widgetexplorer/widgetexplorer.cpp a739a17 > dataengines/share/packagestructure/CMakeLists.txt 9a8a8dd > dataengines/share/packagestructure/share_package.h 31d0f6f > dataengines/share/packagestructure/share_package.cpp bd8567e > dataengines/share/shareservice.h 8f6aa76 > dataengines/share/shareservice.cpp 2529878 > krunner/view.cpp 9d33fe5 > ksmserver/CMakeLists.txt 84a8aa3 > ksmserver/screenlocker/greeter/CMakeLists.txt 14a34f0 > ksmserver/screenlocker/greeter/greeterapp.h 4a90faf > ksmserver/screenlocker/greeter/greeterapp.cpp 824ba60 > ksmserver/screenlocker/kcm/CMakeLists.txt 41e04c9 > ksmserver/screenlocker/kcm/kcm.h 6741e47 > ksmserver/screenlocker/kcm/kcm.cpp 28f5e35 > ksmserver/shutdowndlg.cpp 1c00f19 > ksplash/ksplashqml/CMakeLists.txt 16c58a0 > ksplash/ksplashqml/SplashWindow.cpp 807dc9b > plasma-windowed/plasmawindowedcorona.cpp 8096f9c > shell/CMakeLists.txt cb48ab8 > shell/containmentconfigview.cpp 3ec7efe > shell/desktopview.h ea9e555 > shell/desktopview.cpp bbe16f2 > shell/packageplugins/layouttemplate/CMakeLists.txt ba85efb > shell/packageplugins/lookandfeel/CMakeLists.txt 68ff00f > shell/packageplugins/lookandfeel/lookandfeel.h e1c5605 > shell/packageplugins/lookandfeel/lookandfeel.cpp 0f7d6d0 > > shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop > 98faa6b > CMakeLists.txt d9fc33c > shell/packageplugins/qmlWallpaper/wallpaper.h f3cd5d6 > shell/packageplugins/qmlWallpaper/wallpaper.cpp 4aa8c2a > shell/packageplugins/shell/CMakeLists.txt 9b15426 > shell/packageplugins/shell/plasma-packagestructure-plasma-shell.desktop > c001334 > shell/packageplugins/shell/shellpackage.h 744e26c > shell/packageplugins/shell/shellpackage.cpp ad815c1 > shell/packageplugins/wallpaperimages/CMakeLists.txt 9acafc8 > > shell/packageplugins/wallpaperimages/plasma-packagestructure-wallpaperimages.desktop > 6f105d9 > shell/packageplugins/wallpaperimages/wallpaperpackage.h 541e1f7 > shell/packageplugins/wallpaperimages/wallpaperpackage.cpp 9231bce > shell/scripting/scriptengine.cpp ceb7afc > shell/shellcorona.h 3321adf > shell/shellcorona.cpp 187b68c > shell/standaloneappcorona.cpp e98499c > wallpapers/image/backgroundlistmodel.h 0fa0d92 > wallpapers/image/backgroundlistmodel.cpp 0042c3c > wallpapers/image/image.h 4fb87d2 > wallpapers/image/image.cpp 209ed67 > > Diff: https://git.reviewboard.kde.org/r/122524/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel