> On Feb. 12, 2015, 5:16 p.m., David Edmundson wrote: > > kcms/access/kaccess.cpp, line 347 > > <https://git.reviewboard.kde.org/r/122540/diff/2/?file=348506#file348506line347> > > > > Sorry I wasn't clear. > > > > Not here. > > This needs to remain a unique ID. > > > > I meant action->setText(i18n())
ah, I was wondering how that would survive language changes... thanks! - Frederik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122540/#review75930 ----------------------------------------------------------- On Feb. 12, 2015, 5:01 p.m., Frederik Gladhorn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122540/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 5:01 p.m.) > > > Review request for Plasma, Jonathan Riddell, Sebastian Sauer, and Jeremy > Whiting. > > > Repository: plasma-desktop > > > Description > ------- > > This patch adds a simple check box to the KCM which enables the screen > reader. > It additionally sets up the default shortcut - Meta-Alt-S which is the > same as in Gnome. Using the same shortcut is of course extremely > important, since blind users rely on an easy way to activeate the screen > reader. > > For now the whole process is hard-coded to Orca since there are no real > alternatives for Linux screen readers at the moment. > > The gconfig call which disables the screen reader will make Orca exit. > It still needs to be launched manually. > > I don't have much time for cleaning up the KCM, so help would be very much > appreciated. > There are a lot of low hanging fruits for cleanup there. Also the port to > kf5, away from deprecated stuff is by far not complete. > > > Diffs > ----- > > kcms/access/CMakeLists.txt 55990d2 > kcms/access/accessibility.ui 2e0db83 > kcms/access/kaccess.h e101de4 > kcms/access/kaccess.cpp 2419efb > kcms/access/kcmaccess.cpp 7e0217d > > Diff: https://git.reviewboard.kde.org/r/122540/diff/ > > > Testing > ------- > > This allows me to start and stop Orca using meta-alt-s or the kcm. > > > Thanks, > > Frederik Gladhorn > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
