----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122598/#review76163 -----------------------------------------------------------
This is fine from an interaction perspective, however layout-wise the first checkbox should be left-aligned (the next two elements are dependent on it anyway). The "After" indeed be put in the same line. "Lock Screen on resume" should also be left aligned, it can be put on the bottom to not break overall alignment. - Thomas Pfeiffer On Feb. 16, 2015, 7:42 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122598/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 7:42 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > ------- > > This improves usability over setting the timeout to 0. > Defaults behaviour is unchanged > > BUG: 342596 > > > Diffs > ----- > > ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg d5a82b7 > ksmserver/screenlocker/kcm/kcm.ui 71d2cb0 > ksmserver/screenlocker/ksldapp.cpp e23b50f > > Diff: https://git.reviewboard.kde.org/r/122598/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > a.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/858a9415-352d-48c5-bb1c-e2b60b23ab06__a.png > aleix suggests doing this...thoughts? > > https://git.reviewboard.kde.org/media/uploaded/files/2015/02/16/4d9fbaed-dca8-4000-913e-c352696a975f__a1.png > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
