----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121856/#review76323 -----------------------------------------------------------
Could you please add some documentation including example usage and maybe a test qml file? src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h <https://git.reviewboard.kde.org/r/121856/#comment52597> I'm against a setter for currentDesktopName - Martin Gräßlin On Feb. 19, 2015, 6:25 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121856/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 6:25 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > This is a thin proxy around KWindowSystem exposing most of its methods to qml > via KWindowSystem item in an org.kde.kwindowsystem import. > > It uses QWindow instead of WId parameters so you can just pass a qml Item, > such as a Plasma Dialog as parameter for ease of use (and so you cannot mess > with others windows without effort, also I don't know what "WId" would > translate to anyway). It omits all those methods that return WId/QWindow as I > don't know how expensive QWindow::fromWinId is or who takes ownership of it. > We need to decide which methods make sense in this import. > > Methods that have signals and don't take parameters are turned into > full-fledged properties (like currentDesktop, numberOfDesktops, etc) and the > rest stays Q_INVOKABLE. > > > Diffs > ----- > > src/qmlcontrols/CMakeLists.txt 39c39a5 > src/qmlcontrols/kwindowsystemplugin/CMakeLists.txt PRE-CREATION > src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.h PRE-CREATION > src/qmlcontrols/kwindowsystemplugin/kwindowsystemplugin.cpp PRE-CREATION > src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h PRE-CREATION > src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.cpp PRE-CREATION > src/qmlcontrols/kwindowsystemplugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121856/diff/ > > > Testing > ------- > > The properties work and change accordingly (compositing active signal doesn't > seem to be emitted by KWindowSystem in the first place, at least > Ctrl+Shift+F12 doesn't make it change), the forceActivateWindow method works > for Review 121807 > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
