----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76459 -----------------------------------------------------------
src/qmlpackagelauncher/CMakeLists.txt <https://git.reviewboard.kde.org/r/122667/#comment52668> Maybe it would make sense to call it "kpackagelauncher-qml"? src/quickaddons/kpackageview.h <https://git.reviewboard.kde.org/r/122667/#comment52669> I would assume applications are using a Window/ApplicationWindow. This way the view is not needed anymore and we can have different kinds of applications. I like where this is going! :) - Aleix Pol Gonzalez On Feb. 21, 2015, 7:26 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122667/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2015, 7:26 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > This is still a bit rough but adding it there for early feedback. comes from > the fact that I would like a standard-ish way for KDE apps to do QML based > apps > > It adds 3 things: > * KPackage support to QmlObject: the class is done to easily load QML without > using qquickview, since I want to push loading qml from KPackages, adding > kpackage support to this class seems to make sense > * qmlpackagelauncher: tiny tool to launch qml apps from qml packages: > supports both the case the root object is a qquickitem or an > ApplicationWindow qtquickcomponent(that is a window in itself) puts proper > window title and icon, sets the kaboutdata from the metadata file, binds > commandline arguments in the context (kinda feel some other bindings/API > could be needed) > * KPackageView: is a qquickview that loads kpackages... seeing that the > direction from Qt of using ApplicationWindow as root item makes me a bit > unsure wether to add this tough > > > Diffs > ----- > > src/quickaddons/CMakeLists.txt 8272f1f > src/quickaddons/kpackageview.h PRE-CREATION > src/quickaddons/kpackageview.cpp PRE-CREATION > tests/CMakeLists.txt a8abfaf > tests/helloworld/contents/ui/main.qml PRE-CREATION > tests/helloworld/metadata.desktop PRE-CREATION > CMakeLists.txt 52a698a > src/CMakeLists.txt 32da8a5 > src/kdeclarative/CMakeLists.txt 052b9e2 > src/kdeclarative/qmlobject.h a0a74d3 > src/kdeclarative/qmlobject.cpp 00478b4 > src/qmlpackagelauncher/CMakeLists.txt PRE-CREATION > src/qmlpackagelauncher/main.cpp PRE-CREATION > src/qmlpackagelauncher/view.h PRE-CREATION > src/qmlpackagelauncher/view.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122667/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel