----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76707 -----------------------------------------------------------
dataengines/geolocation/location_ip.cpp <https://git.reviewboard.kde.org/r/122736/#comment52825> wifiAccessPoints.append(QJsonObject{ {QStringLiteral("macAddress"), accessPoint->hardwareAddress()} }); dataengines/geolocation/location_ip.cpp <https://git.reviewboard.kde.org/r/122736/#comment52824> You might want to use toJson(QJsonDocument::Compact) to save a little bit of bandwidth - Kai Uwe Broulik On Feb. 27, 2015, 9:13 vorm., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122736/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 9:13 vorm.) > > > Review request for Plasma, Jan Grulich and Lukáš Tinkl. > > > Repository: plasma-workspace > > > Description > ------- > > Adds a dependency to NetworkManager and queries the available wifi > access points to include in the request to the location service. > > > Diffs > ----- > > CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489 > dataengines/geolocation/CMakeLists.txt > efdcd14940b47a64b4e70dce69bdeeffdc6873f5 > dataengines/geolocation/geolocation.h > fcc95086b97b6c96c0ab9bce3cac703d96d0b43e > dataengines/geolocation/geolocation.cpp > e02060e157a29902e594310102555096bd619e2e > dataengines/geolocation/location_ip.cpp > 3a13dc3018bff482c48098e1827f31c5fa3184cc > > Diff: https://git.reviewboard.kde.org/r/122736/diff/ > > > Testing > ------- > > Tested with my available networks and checked position on openstreetmaps. > Basically it even put me in the right room of the building I'm in. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
