----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76709 -----------------------------------------------------------
src/ActionClasses.cpp <https://git.reviewboard.kde.org/r/122450/#comment52826> Do we need to explicitly call `setGlobalShortcut( KShortcut() )` or can one just omit it alltogether? - Vishesh Handa On Feb. 6, 2015, 8:06 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122450/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2015, 8:06 a.m.) > > > Review request for Amarok and Plasma. > > > Repository: amarok > > > Description > ------- > > Amarok used to grab the keys for: > * Qt::Key_MediaPlay > * Qt::Key_MediaStop > * Qt::Key_MediaNext > * Qt::Key_MediaPrevious > > As those are global shortcuts they are taken away from any other > application when Amarok is running. E.g. if I watch a movie in VLC > and press the media play button (which VLC handles) Amarok will start > playback if it's running. If Amarok is not running, VLC will pause > the playback. This shows that a multi-media application should not > globally grab these keys. > > In addition we just introduced a change [1] in plasma-workspace for the > Plasma/5.3 release to grab these shortcuts and bind them to the > mpris2 dataengine. Now the mpris2 engine handles those shortcuts and > delegates to the currently active application. > > [1] > http://commits.kde.org/plasma-workspace/409fdfab03e7a0b5a61e7796e1fba85b143eab3b > > > Diffs > ----- > > src/ActionClasses.cpp 3f6a63e073f76db8ec05daf531dd2d828d3f9c0d > src/MainWindow.cpp 484f4251f8911f1c4e63f61ae17efd7b17b5c4e6 > > Diff: https://git.reviewboard.kde.org/r/122450/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
