> On March 11, 2015, 2:07 p.m., David Edmundson wrote: > > src/quickaddons/configmodule.cpp, line 102 > > <https://git.reviewboard.kde.org/r/122886/diff/1/?file=354025#file354025line102> > > > > when combined with your other KCModule patch you have a crash. > > > > From KCModule docs: > > This sets the KAboutData returned by aboutData() The about data is now > > owned by KCModule. > > > > So this will result in a double delete. > > Same for the delete in setAboutData. > > Marco Martin wrote: > hmm, would work actually creating a copy of this about data in the > wrapper class?
Yeah, I think that would work. > On March 11, 2015, 2:07 p.m., David Edmundson wrote: > > src/quickaddons/configmodule.h, line 338 > > <https://git.reviewboard.kde.org/r/122886/diff/1/?file=354024#file354024line338> > > > > This documentation tells me nothing, and I'm not sure what this does > > from the method name. > > Marco Martin wrote: > eh, I have no idea about this method as well :/ > it's a thing exported by KCModule, so here just wrapping it. > it's presumably used for some reason, somewhere, but even from the code > it's not understandable. > on lxr, seems the only place where is used is KInfoCenter > > http://lxr.kde.org/source/kde/workspace/kinfocenter/infocenter.cpp?v=kf5-qt5 > > (may be worth even just dumping it...) ++ for killing it here. Then it becomes not our problem :D - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77304 ----------------------------------------------------------- On March 10, 2015, 11:28 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122886/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 11:28 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > This is a QObject-based fork of KCmodule, with the api slightly adaped to be > more declarative friendly. > it loads a qml file that then will be able to access its instance as "kcm" or > as the "KCM" attached property, like what happens in plasmoids (for how > attached proeprties work, unfortunately only properties of the base class > will be accessible). > They will be loaded in systemsettings by review 122887 > > > Diffs > ----- > > src/quickaddons/CMakeLists.txt 3c7a34b > src/quickaddons/configmodule.h PRE-CREATION > src/quickaddons/configmodule.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122886/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
