----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123098/#review77959 -----------------------------------------------------------
This assumes that your systray is at the same position as the notification popup is, which is the default, true, but I'm a bit worried about cases where your systray is in a different position (and I do have that patch that allows you to select different popups position). Then it might be confusing if suddenly you don't see the popup (especially on bigger screens)? - Martin Klapetek On March 22, 2015, 1:25 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123098/ > ----------------------------------------------------------- > > (Updated March 22, 2015, 1:25 p.m.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > Persistent notifications are stored in the history. When you have currently > opened the plasmoid, you would see the notification right away, but it is > then covered by the popup of exactly the same notification. I tend to keep my > tray opened when copying lots of files and when the job finishes, I get this > "odd" behavior. > > > Diffs > ----- > > applets/notifications/package/contents/ui/Notifications.qml 4312774 > > Diff: https://git.reviewboard.kde.org/r/123098/diff/ > > > Testing > ------- > > - knotificationdbustest with plasmoid closed yields 3+1 popups > - knotificationdbustest with plasmoid opened yields no popups but the history > fills accordingly > - notify-send results in a popup either way > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
