> On March 24, 2015, 1:33 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: New Screenshot - notifications_config.png > > <https://git.reviewboard.kde.org/r/122842/#fcomment376> > > > > We usually have a title over here. > > Martin Klapetek wrote: > Ah yeah, I thought there's something missing. That should be a different > patch though.
In fact, I do have a title here (it's the "name" property in ConfigCategory which totally is set). I'm not sure how it became missing in that screenshot... - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/#review77996 ----------------------------------------------------------- On March 24, 2015, 1:19 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122842/ > ----------------------------------------------------------- > > (Updated March 24, 2015, 1:19 p.m.) > > > Review request for Plasma. > > > Bugs: 344841 > https://bugs.kde.org/show_bug.cgi?id=344841 > > > Repository: plasma-workspace > > > Description > ------- > > Allows to select each corner and top or bottom edges of the screen. > > The radio selection thing is currently a bit ugly and I'd like to ask for > suggestions on it (I originally wanted to add VDG here but there's no vdg > group (?) so I'll post in the forums). > > > Diffs > ----- > > applets/notifications/CMakeLists.txt 113d731 > applets/notifications/lib/CMakeLists.txt PRE-CREATION > applets/notifications/lib/notificationsapplet.h PRE-CREATION > applets/notifications/lib/notificationsapplet.cpp PRE-CREATION > applets/notifications/package/contents/ui/Notifications.qml 4312774 > applets/notifications/package/contents/ui/ScreenPositionSelector.qml > PRE-CREATION > applets/notifications/package/contents/ui/configNotifications.qml cda9ac9 > applets/notifications/package/metadata.desktop 333fa2c > applets/notifications/plugin/notificationshelper.h ca0b63b > applets/notifications/plugin/notificationshelper.cpp cd8a5a5 > > Diff: https://git.reviewboard.kde.org/r/122842/diff/ > > > Testing > ------- > > All positions work > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/06/f80f9345-3d5f-49b4-83d7-16ecbfbc607a__notification_pos.png > New Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/11/e1fd3405-b008-4d6e-90c7-2000ab011008__notifications_config.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
