> On March 27, 2015, 2:20 p.m., David Edmundson wrote: > > is this redundant now?
Yes, Tomaz said he'll close it. - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123142/#review78121 ----------------------------------------------------------- On March 26, 2015, 7:47 p.m., Tomaz Canabrava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123142/ > ----------------------------------------------------------- > > (Updated March 26, 2015, 7:47 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Plasma-desktop uses Boost::optional on a few places, but it stored the value > as boolean ( bool thisValid = currentValue; for instance ), the issue is > that boost::optional conversion to bool must be explicit, thus a static_cast > is needed. > > > Diffs > ----- > > lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 > > Diff: https://git.reviewboard.kde.org/r/123142/diff/ > > > Testing > ------- > > compiles. > > > Thanks, > > Tomaz Canabrava > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
