----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78416 -----------------------------------------------------------
I think it's on the right track, biggest complain is the neaming of the methods so far wallpapers/image/backgroundlistmodel.h (line 92) <https://git.reviewboard.kde.org/r/123211/#comment53651> setPendingDeletion()? wallpapers/image/backgroundlistmodel.h (line 93) <https://git.reviewboard.kde.org/r/123211/#comment53652> this function is not clear what it actually does looks like a verb but returns a list? i tought it was actually *doing* the deletion, maybe either this could directly call removewallpaper or be renamed to something else like wallpapersAwaitingDeletion() or deletionCandidates() - Marco Martin On April 2, 2015, 4:24 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123211/ > ----------------------------------------------------------- > > (Updated April 2, 2015, 4:24 p.m.) > > > Review request for Plasma. > > > Bugs: 338729 > https://bugs.kde.org/show_bug.cgi?id=338729 > > > Repository: plasma-workspace > > > Description > ------- > > This patch is adding a confirmation dialog which is being called before we > remove a wallpaper. > > > Diffs > ----- > > wallpapers/image/backgroundlistmodel.h 01b528d > wallpapers/image/backgroundlistmodel.cpp d062650 > wallpapers/image/image.h a00e431 > wallpapers/image/image.cpp f0c672a > wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f > wallpapers/image/imagepackage/contents/ui/config.qml 2108082 > > Diff: https://git.reviewboard.kde.org/r/123211/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > dialog > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png > wallpaper remove > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/8acc3dab-4c2a-4cc2-9ba3-9893e42c32d3__wallpaper_undo.png > wallpaper restore > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/4b23e100-194a-4557-926c-d7af252f15d7__wallpaper_undo3.png > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel