----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123282/#review78621 -----------------------------------------------------------
CMakeLists.txt (line 34) <https://git.reviewboard.kde.org/r/123282/#comment53789> Make them optional? Modules/energy/CMakeLists.txt (line 21) <https://git.reviewboard.kde.org/r/123282/#comment53788> Why is it commented out? Modules/energy/package/contents/ui/Graph.qml (line 94) <https://git.reviewboard.kde.org/r/123282/#comment53794> Is it fine to hardcode the colors? Modules/energy/package/contents/ui/main.qml (line 384) <https://git.reviewboard.kde.org/r/123282/#comment53793> What do we need to have there? Modules/energy/statisticsprovider.cpp (line 183) <https://git.reviewboard.kde.org/r/123282/#comment53797> Looks quite big for a lambda, make it a method? Modules/energy/wakeupmodel.cpp (line 129) <https://git.reviewboard.kde.org/r/123282/#comment53795> Nitpicking but: (*it).something is clearer as it->something kcmcontainer.cpp (line 62) <https://git.reviewboard.kde.org/r/123282/#comment53786> unrelated? - Aleix Pol Gonzalez On April 7, 2015, 3:37 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123282/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 3:37 p.m.) > > > Review request for Plasma. > > > Repository: kinfocenter > > > Description > ------- > > I assume everyone knows by now. > > > Diffs > ----- > > CMakeLists.txt 139a49e > Modules/CMakeLists.txt 37a1faf > Modules/energy/CMakeLists.txt PRE-CREATION > Modules/energy/Messages.sh PRE-CREATION > Modules/energy/batterymodel.cpp PRE-CREATION > Modules/energy/config-kcm.h.cmake PRE-CREATION > Modules/energy/kcm.cpp PRE-CREATION > Modules/energy/kcm_energyinfo.desktop PRE-CREATION > Modules/energy/package/contents/ui/Graph.qml PRE-CREATION > Modules/energy/package/contents/ui/main.qml PRE-CREATION > Modules/energy/package/metadata.desktop PRE-CREATION > Modules/energy/statisticsprovider.h PRE-CREATION > Modules/energy/statisticsprovider.cpp PRE-CREATION > Modules/energy/wakeupmodel.h PRE-CREATION > Modules/energy/wakeupmodel.cpp PRE-CREATION > ToolTips/ktooltipwindow_p.h 0813e6a > ToolTips/ktooltipwindow_p.h 0813e6a > infocenter.cpp 1ebbf71 > kcmcontainer.cpp c76ac65 > sidepanel.cpp f30ef4b > > Diff: https://git.reviewboard.kde.org/r/123282/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
