> On April 7, 2015, 3:28 nachm., Kai Uwe Broulik wrote: > > applets/timer/package/contents/ui/configAppearance.qml, line 43 > > <https://git.reviewboard.kde.org/r/123274/diff/4/?file=360398#file360398line43> > > > > HIG says Checkboxes should always be positive, ie. "Show seconds" and > > then enable it by default instead; also makes it consistent with the other > > one > > Bernhard Friedreich wrote: > current config (main.xml) uses hideSeconds as property - how can this be > migrated properly for our users if we are changing this? Or don't we have to > care about this because the ui wasn't there in plasma 5.x yet? > > David Edmundson wrote: > set the default to true in the xml file? > > Bernhard Friedreich wrote: > I ment if some users had already used the property hideSeconds and we are > changing the config-key to showSeconds then they will have to configure it > again. > > David Edmundson wrote: > ah, if it's not been released then we don't care. > > In a hypothetical example where it was released, you would use > kconf_update: > https://techbase.kde.org/Development/Tools/Using_kconf_update
afaik it hasn't been released yet. I've already updated the last diff to reflect this change. - Bernhard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78632 ----------------------------------------------------------- On April 7, 2015, 5:20 nachm., Bernhard Friedreich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123274/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 5:20 nachm.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > Added tab "General" and "Appearance" in the config ui > > General contains the bits about command execution after the timer has > completed > Appearance contains the ability to hide seconds and showing the title > > The configuration option for showing the title is a bit buggy (again) > This bugreport explains the wrong scaling of the title: 304923 > > I've converted this plasmoid from being qml only to c++ and qml because it > looks like KProcess has no qml interface yet (and I didn't find any place > where to start) > > [Edit 1]: updated to use QProcess > [Edit 2]: renamed General to Advanced and moved it down to make "Appearance" > the default tab on opening > [Edit 3]: updated layers in the config ui and make the command textfield > depend upon the checkbox > [Edit 4]: fixed many things mentioned by Kai Uwe Broulik > > > Diffs > ----- > > applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f > applets/timer/package/contents/config/config.qml PRE-CREATION > applets/timer/package/contents/config/main.xml > 6d4cdd38965e57d351df999b76d759af6bbe724c > applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION > applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION > applets/timer/package/contents/ui/timer.qml > f675b93bda59eb161fe10b5f575eaa2082b822e0 > applets/timer/plugin/qmldir PRE-CREATION > applets/timer/plugin/timer.h PRE-CREATION > applets/timer/plugin/timer.cpp PRE-CREATION > applets/timer/plugin/timerplugin.h PRE-CREATION > applets/timer/plugin/timerplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123274/diff/ > > > Testing > ------- > > Tested using plasmashell directly and using plasmoidviewer > > > File Attachments > ---------------- > > Appearance Tab > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png > Advanced Tab > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png > > > Thanks, > > Bernhard Friedreich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
