> On April 14, 2015, 5:35 p.m., David Edmundson wrote: > > shell/desktopview.h, line 32 > > <https://git.reviewboard.kde.org/r/123362/diff/1/?file=361080#file361080line32> > > > > This is currently used > > > > git grep dashboardShown > > desktoppackage/contents/views/Desktop.qml: visible: > > desktop.dashboardShown > > desktoppackage/contents/views/Desktop.qml: value: > > desktop.dashboardShown ? 0.3 : 1 > > Marco Martin wrote: > yeah, i have a diff for plasma-desktop as well > i could leave the property for compatibility, even tough woudln't be very > useful
I'm fine with killing the property. I wouldn't be fine with causing the desktop to not load. I assume you just removed the black rectangle both these properties are used in? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123362/#review78926 ----------------------------------------------------------- On April 14, 2015, 4:49 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123362/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 4:49 p.m.) > > > Review request for kwin and Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > since now the show desktop effect is a neat kwin effect, use it instead of > the old dashboard that changed the window type on the fly > > > Diffs > ----- > > shell/desktopview.h d47dcd8 > shell/desktopview.cpp aec29dc > shell/shellcorona.cpp 4aff26e > > Diff: https://git.reviewboard.kde.org/r/123362/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel