----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123448/#review79298 -----------------------------------------------------------
Note that currently if you press "Apply" in the applet's config dialogs, the Apply will not become disabled but will stay enabled forever. - Martin Klapetek On April 21, 2015, 5:04 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123448/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 5:04 p.m.) > > > Review request for Plasma. > > > Bugs: 346431 > https://bugs.kde.org/show_bug.cgi?id=346431 > > > Repository: plasma-desktop > > > Description > ------- > > The "Wallpaper" and the "Mouse Actions" category should always show > the message dialog if they have pending changes. > > Futhermore there is no need to check if there are pending changes, > since we already know that because of the "Apply" Button. > So we don't need the "configurationHasChanged" function anymore. > > > Diffs > ----- > > desktoppackage/contents/configuration/AppletConfiguration.qml 9e61cc0 > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml 68301ad > > Diff: https://git.reviewboard.kde.org/r/123448/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel