> On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: > > autotests/globaltest.cpp, line 96 > > <https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96> > > > > This should be (1).txt? > > Ashish Bansal wrote: > imho if my any file starts with ".", that's my dot file and I would not > like suggestName to remove the dotness of file instead it should > append/increment no. at end. But if you still find no. at the starting as > better use case, then no problem I'll change it right away.
I agree, a dot file should keep starting with a dot. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review78559 ----------------------------------------------------------- On April 4, 2015, 1:15 p.m., Ashish Bansal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123224/ > ----------------------------------------------------------- > > (Updated April 4, 2015, 1:15 p.m.) > > > Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. > > > Repository: kio > > > Description > ------- > > For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong > name(something like filename-1 2.6.tar.gz). > Expected name: filename-1.6 (1).tar.gz > > > Diffs > ----- > > autotests/globaltest.cpp ff8725d > src/core/global.cpp f18ac10 > > Diff: https://git.reviewboard.kde.org/r/123224/diff/ > > > Testing > ------- > > Works fine! > > > Thanks, > > Ashish Bansal > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
