----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123535/#review79582 -----------------------------------------------------------
I like the idea of showing such an error message. shell/shellmanager.cpp (line 186) <https://git.reviewboard.kde.org/r/123535/#comment54372> you could also use nullptr here to explicitly go into the overload taking a QWidget. "0" is a valid window id which most likely doesn't exist. - Martin Gräßlin On April 27, 2015, 4:55 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123535/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 4:55 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > BUG: 346792 > > > Diffs > ----- > > shell/shellmanager.cpp c6137ad63346c306adeab8d15fb6914ef2533aa8 > > Diff: https://git.reviewboard.kde.org/r/123535/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel