-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123540/
-----------------------------------------------------------
Review request for KDE Frameworks and Plasma.
Bugs: 345973
https://bugs.kde.org/show_bug.cgi?id=345973
Repository: knotifications
Description
-------
This patch checks if the properties being set are actually changed before
emitting the update signal, which would cause a re-emit of the notification.
Furthermore, NotifyByPopup now no longer changes the KNotification object when
the server does not support certain capabilities but only does local checking
and modifications.
This fixes KNotification use with Ubuntu's NotifyOSD.
Diffs
-----
src/knotification.cpp afac82f
src/notifybypopup.cpp 316ff2b
Diff: https://git.reviewboard.kde.org/r/123540/diff/
Testing
-------
Before this patch there was a continous loop of setting empty actions because
the server does not support them -> triggers update -> triggers setting empty
actions -> triggers update -> and so on. This made the notification popup look
stuck and would block all other notifications from appearing (NotifyOSD
supports only one popup at a time).
Now everything behaves correctly.
Thanks,
Martin Klapetek
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
