> On May 7, 2015, 1:02 p.m., David Edmundson wrote:
> > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 51
> > <https://git.reviewboard.kde.org/r/123674/diff/1/?file=367379#file367379line51>
> >
> > there's a behavioural change if
> >
> > model.source == ""
> > and
> > model.kcm == ""
> >
> > old code would unset everything, and load an empty page this will leave
> > it as the current page.
> > I don't think that's a problem? A warning might be good
an
} else {
main.sourceFile = "";
}
at the end should give it the old behavior i think?
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123674/#review80038
-----------------------------------------------------------
On May 7, 2015, 12:41 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123674/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 12:41 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> this is the plasma shell package part of the kcm load of plasmoid config
> dialogs.
>
>
> Diffs
> -----
>
> desktoppackage/contents/configuration/AppletConfiguration.qml 4daccdd
> desktoppackage/contents/configuration/ConfigCategoryDelegate.qml 301ea29
> desktoppackage/contents/configuration/ConfigurationKcmPage.qml PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/123674/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
