----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123682/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-desktop Description ------- This patch ports the kcm fonts to QML. Diffs ----- kcms/fonts/CMakeLists.txt d73636e kcms/fonts/fonts.cpp 74da799 kcms/fonts/fonts.desktop 1cdad40 kcms/fonts/fonts.h d98bbe2 kcms/fonts/kcm_fonts.desktop PRE-CREATION kcms/fonts/package/contents/ui/main.qml PRE-CREATION kcms/fonts/package/metadata.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123682/diff/ Testing ------- Everything works execpt from the ComboBox and the FontDialog ("Configure Font"). * FontDialog If you open the kcm inside from the system settings, everything is ok. If you use kcmshell5 fonts, the FontDialog is opening behing the kcm window. In order to solve this issue we must use the setTransientParent, but how can i do that in the FontDialog? * ComboBox If you open the kcm with the "kcmshell5 fonts", the dropdown menu renders fine. But if you open it inside from the system settings, the dropdown menu, renders in the left of the ComboBox. Also these two signals (main.qml line 295) onDpiChanged onAliasingChanged are being emitted but the kcm.needsSave doesn't work... File Attachments ---------------- fonts qml https://git.reviewboard.kde.org/media/uploaded/files/2015/05/08/833710e7-9569-4cd3-a02f-3ebe95a1c914__kcm_fonts_qml.png Thanks, Antonis Tsiapaliokas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
