> On May 12, 2015, 3:44 p.m., Kai Uwe Broulik wrote:
> > > For compatibility, applets without X-Plasma-RequiredExtensions=LaunchApp 
> > > will still have own engine
> > 
> > You mean SharedEngine? :)

that :)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123736/#review80243
-----------------------------------------------------------


On May 12, 2015, 3:30 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123736/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 3:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> use a single shared QQmlEngine for all applets, tooltip and wallpapers (each 
> of which used to use an own one)
> views are still separed engines because being View subclass of QQuickView 
> which api unfortunately requires it (a qquickengine can be passed to the 
> ctor, but in that case they would share their QQmlContext, which wouldn't 
> work)
> 
> For compatibility, applets without X-Plasma-RequiredExtensions=LaunchApp will 
> still have own engine
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tooltipdialog.cpp feeacc3 
>   src/plasmaquick/appletquickitem.cpp c6fcf22 
>   src/plasmaquick/packageurlinterceptor.h 36c85a9 
>   src/plasmaquick/packageurlinterceptor.cpp 5f77c3a 
>   src/plasmaquick/private/appletquickitem_p.h a1ec683 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp fcaca4b 
> 
> Diff: https://git.reviewboard.kde.org/r/123736/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to