----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/#review80256 -----------------------------------------------------------
applets/taskmanager/package/contents/ui/main.qml (line 237) <https://git.reviewboard.kde.org/r/123738/#comment55051> Two ternary operators in one row is _really_ hard to read! Please consider making it readable with if - elseif - else. flow: { if (...) { } ... } etc. I really like how this change makes drag/drop much more easier to follow! Great change imho, just the style of the change could be made more readable. - Mark Gaiser On mei 12, 2015, 7:26 p.m., Kåre Särs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123738/ > ----------------------------------------------------------- > > (Updated mei 12, 2015, 7:26 p.m.) > > > Review request for Plasma and Eike Hein. > > > Repository: plasma-desktop > > > Description > ------- > > When we have "Force row settings" and more than one row of items, the items > start to jump around and it is had to keep track of where each item is. > > The atached patch changes the flow to TopToBottom, in stead of LeftToRight, > when we have a horizontal layout and "Force row settings", and similarly to > LeftToRight in vertical layout. (In practice the vertical layout is always > one column and this patch has no effect) > > Here are two videos that describe the problem > First is the row major where taskbar items jump around: > https://youtu.be/8udr2DJKobw > > And the second with a patched taskbar where the items jump around a lot less: > https://youtu.be/bk17gnu1ETo > > > Diffs > ----- > > applets/taskmanager/package/contents/ui/main.qml 98ba7c3 > > Diff: https://git.reviewboard.kde.org/r/123738/diff/ > > > Testing > ------- > > I'm using this patch on all my installations and tried the vertical layout > > > Thanks, > > Kåre Särs > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
