----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123834/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-workspace Description ------- With its current architecture, KNotification can cause crashes on logout (and also cause asserts in certain situations, that will be another fix). So in the meantime, this replaces the KNotification-in-a-thread with Phonon directly. This is exactly what KNotification would do. This is for the time being until the crash on logout is sorted out. Additionally, this also fixes logout sound which was missing before. This uses normal KNotification as at that point we don't need to be threading or anything, so KNotification is just safe. Diffs ----- CMakeLists.txt 8ffccad ksmserver/CMakeLists.txt c0543e2 ksmserver/shutdown.cpp 7600c30 ksmserver/startup.cpp f79fd4f Diff: https://git.reviewboard.kde.org/r/123834/diff/ Testing ------- Login sound works as expected, logout sound as well. Also tested by couple other people. Thanks, Martin Klapetek
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
