On Tuesday, May 26, 2015 10:47:11 Martin Gräßlin wrote: > > Could you make this feature, and therefore the dependency on Network > > Manager, optional at build time? > > as I was addressed directly: no I won't do that as I don't see the need and > don't have the time for testing that. > > A patch doing that could be evaluated, I would recommend to not accept such > a patch, but others in the team might see it differently. > > In my opinion NetworkManagerQt is a defacto hard-dependency of the combined > product Plasma we provide, thus also plasma-workspace can depend on it. My > system I'm just writing on doesn't use NetworkManager either, nevertheless > I do not think that compiling without support for NetworkManager is a valid > use case which we as the devs should spend time on. Given that we all just > run kdesrc-build which compiles everything (which is the same the CI does) > we would not be able to track a build failure. I have been at that place > with KWin many times and want our CMake dependencies to be as accurate to > what we can guarantee as possible. Even more I just recently noticed that > distributions do the packaging mostly automatic nowadays resulting in very > important, but optional, dependencies to not be picked up.
I would prefer having network-manager-qt as optional build dependency. Just feels that way from having dealt with it for years. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel