> On May 18, 2015, 10:46 a.m., Martin Klapetek wrote: > > Fwiw, I think it would be much better if the dataengine actually signalled > > the disk space change rather than polling, then the applet could just > > handle the incoming "changed" signals -> less polling around. > > Yoann Laissus wrote: > What mechanism do you think we can use to monitor disk space changes ? > inotify/fanotify ? > I'm afraid that the load would be higher with that approach. (with > network mounts, for instance)
It's fine if the dataengine polls for the space, but then the applet wouldn't have to unless the space actually changed. The dataengine can watch it anyhow and if the free space changes, it sends out the signal to which the applet would be connected and update its visualization. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/#review80566 ----------------------------------------------------------- On May 17, 2015, 1:01 p.m., Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123817/ > ----------------------------------------------------------- > > (Updated May 17, 2015, 1:01 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Previously, it was set to 0 so the space indicator was never refreshed. > > > Diffs > ----- > > applets/devicenotifier/package/contents/ui/devicenotifier.qml > 1fb3d28736fc5effb7e6a6e5940a7bab28c19798 > > Diff: https://git.reviewboard.kde.org/r/123817/diff/ > > > Testing > ------- > > > Thanks, > > Yoann Laissus > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
