----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124039/#review81308 -----------------------------------------------------------
to check I've understood this: panel and dialog use "background effect". our theme code to say if we should use the regular SVGS or opaque fallback is monitoring the wrong effect. this fixes that and moves a slot to a lambda - David Edmundson On June 8, 2015, 10:01 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124039/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 10:01 a.m.) > > > Review request for Plasma and KDE Usability. > > > Bugs: 342934 and 348154 > http://bugs.kde.org/show_bug.cgi?id=342934 > http://bugs.kde.org/show_bug.cgi?id=348154 > > > Repository: plasma-framework > > > Description > ------- > > Only the background contrast provides real contrast for the background, the > blur doesn't improve readability that much, so when background contrast is > disabled we use the less transparent svgs instead. This makes the panels look > similarly white (so no more embarrasing reviews on news websites) to the > regular theme and significantly improves readability. > > > Diffs > ----- > > src/plasma/private/theme_p.h 68336f0 > src/plasma/private/theme_p.cpp f64265b > > Diff: https://git.reviewboard.kde.org/r/124039/diff/ > > > Testing > ------- > > Blur: off, Contrast: off -> opaque > Blur: on, Contrast: off -> opaque (previously transparent) > Blur: off, Contrast: on -> transparent, good readability (previously opaque) > Blur: on, Contrast: on -> transparent, good readability > > The regular SVG could become slightly transparent though, it looks like the > "opaque" variant that is used when compositing is disabled. > > With Breeze Dark transparency without contrast isn't that strong but still > readability is significantly improved. > > > File Attachments > ---------------- > > Contrast enabled > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/a2f7a225-b0f9-4e91-ac42-5d58cd4318f6__backgroundcontraston.png > Contrast off (before) > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/9e6b0d51-f58a-483e-bbf5-fee942739f44__backgroundcontrastoffbefore.png > Contrast off (after) > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/5c609063-bbfc-4d8d-b4dd-220154523415__backgroundcontrastoffafter.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
