-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124037/#review81318
-----------------------------------------------------------

Ship it!


I saw Vishesh running with the laptop in his hands here, so he's in danger of 
also running into this bone-breaking problem.

Perhaps we can avoid the repitition of the title in the maintext and make it 
fit better this way?

- Sebastian Kügler


On June 7, 2015, 7:09 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124037/
> -----------------------------------------------------------
> 
> (Updated June 7, 2015, 7:09 p.m.)
> 
> 
> Review request for Plasma, Solid and KDE Usability.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> To prevent David from eventually breaking his bones tumbling down the stairs 
> rushing for his AC adapter, this adds a "Cancel" button to the battery 
> critical notification that allows to cancel the timeout for automatic 
> suspend/shutdown.
> 
> 
> Diffs
> -----
> 
>   daemon/powerdevilcore.h 50e6a50 
>   daemon/powerdevilcore.cpp e90a960 
> 
> Diff: https://git.reviewboard.kde.org/r/124037/diff/
> 
> 
> Testing
> -------
> 
> Got a "Cancel" button only when it was configured to do something, clicking 
> the button from both popup and history cancelled the timeout. (Unfortunately 
> the notification doesn't fit into the popup at all now)
> 
> 
> File Attachments
> ----------------
> 
> Notification with close button
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/07/f99c0164-4436-462f-974b-ddc5df0ce500__powerdevilcanceltimeout.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to