----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/#review81489 -----------------------------------------------------------
A better option would be to call registerService() with QDBusConnectionInterface::ReplaceExistingService and DBusConnectionInterface::AllowReplacement - Lukáš Tinkl On Čer. 15, 2015, 4:30 odp., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124102/ > ----------------------------------------------------------- > > (Updated Čer. 15, 2015, 4:30 odp.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > We're getting lots of reports about notifications not being "closeable on > click" or "not having any actions" or "not having Plasma theme". These all > mostly come from users which have notify-osd package from Unity (ie. Ubuntu > users installing plasma-desktop), but not only. > > So this patch makes Plasma always be the Notification service provider if > that option is enabled in the applet settings and/or if the applet is present > somewhere (otherwise the dataengine is not loaded). On startup, it will get > the PID of the current Notifications service, send SIGTERM to it and register > its own service. > > > Diffs > ----- > > dataengines/notifications/notificationsengine.h 7810787 > dataengines/notifications/notificationsengine.cpp c3bf373 > > Diff: https://git.reviewboard.kde.org/r/124102/diff/ > > > Testing > ------- > > Having notify-osd running, plasmashell starts up, notify-osd is terminated, > Plasma notifications appear. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
