> On July 7, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote: > > Looks good to me too, as long as it works. > > OTOH, it looks like a bad reason to offer an homogeneous experience, albeit > > being a not really interesting bit of Plasma. > > Hrvoje Senjan wrote: > I submited this patch to upstream due to two reasons: > 1) number of supported hardware & features is limited at best (according > to link i posted, newest supported mouse is from 2004) > 2) code is already #ifdef'ed, there is a small step to also let the > buildsystem know the same
Oh no, don't get me wrong. Sending the patch upstream is the correct thing to do, or even better: support KDE dependencies on each distribution. But this can be just fine, in this case. If nobody gives you a "ship it" tomorrow, just go with it and push the change. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/#review82157 ----------------------------------------------------------- On July 6, 2015, 8:41 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124275/ > ----------------------------------------------------------- > > (Updated July 6, 2015, 8:41 p.m.) > > > Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Martin > Gräßlin. > > > Repository: plasma-desktop > > > Description > ------- > > Some distros are slowly targetting to get rid of the old libusb (see > discussion in > http://lists.opensuse.org/opensuse-factory/2015-07/msg00158.html) > As the code mouse.[cpp,h] and logitechmouse.[cpp,h] is already ready for such > an option, allow cmake to recognize this also. > > > Diffs > ----- > > kcms/CMakeLists.txt d8a69a3 > kcms/input/CMakeLists.txt ee5c9c3 > > Diff: https://git.reviewboard.kde.org/r/124275/diff/ > > > Testing > ------- > > Builds. > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
