----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102983/#review82364 -----------------------------------------------------------
bluedevil/bluedevilmanager.h (line 109) <https://git.reviewboard.kde.org/r/102983/#comment56751> We use camel case for enumerate's names too. bluedevil/bluedevilmanager.h (line 136) <https://git.reviewboard.kde.org/r/102983/#comment56755> isRfkillSwitchSupported() const; bluedevil/bluedevilmanager.cpp (line 41) <https://git.reviewboard.kde.org/r/102983/#comment56756> Is rfkill supported in BSD? If so then this dev path may be different in that platform. bluedevil/bluedevilmanager.cpp (line 41) <https://git.reviewboard.kde.org/r/102983/#comment56757> Is rfkill supported in BSD? If so then this dev path may be different in that platform. bluedevil/bluedevilmanager.cpp (line 41) <https://git.reviewboard.kde.org/r/102983/#comment56758> Is rfkill supported in BSD? If so then this dev path may be different in that platform. bluedevil/bluedevilmanager.cpp (line 156) <https://git.reviewboard.kde.org/r/102983/#comment56760> bool isValid() const bluedevil/bluedevilmanager.cpp (line 156) <https://git.reviewboard.kde.org/r/102983/#comment56761> bool isValid() const bluedevil/bluedevilmanager.cpp (line 383) <https://git.reviewboard.kde.org/r/102983/#comment56762> Use normalized signal/slots [1]: connect(d->m_rfkill.getFileSystemWatcher(), SIGNAL(fileChanged(QString)), this, SLOT(_k_rfkillChanged(QString))); [1] http://doc.qt.io/qt-4.8/signalsandslots.html bluedevil/test/bluedeviltest.cpp (line 103) <https://git.reviewboard.kde.org/r/102983/#comment56752> Please fix identation. I think the text should "RfkillSwitch supported! Status: " bluedevil/test/bluedeviltest.cpp (line 119) <https://git.reviewboard.kde.org/r/102983/#comment56753> } else { bluedevil/test/bluedeviltest.cpp (line 121) <https://git.reviewboard.kde.org/r/102983/#comment56754> "RfkillSwitch not supported in this platform" - Lamarque Souza On July 11, 2015, 8:43 p.m., Rüdiger Sonderfeld wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/102983/ > ----------------------------------------------------------- > > (Updated July 11, 2015, 8:43 p.m.) > > > Review request for Plasma and Solid. > > > Repository: libbluedevil > > > Description > ------- > > rfkill is a subsystem of the Linux Kernel to disable radio transmitters > (including Bluetooth). This patch adds support for rfkill to libbluedevil. An > interface is added to the Manager class. > > rfkill support is important because gnome uses rfkill to deactivate > bluetooth. Therefore if bluetooth is currently disabled in the > gnome-control-center it can not be used by kde. With this patch the proper > API to reenable bluetooth is provided. > > Disabling bluetooth with rfkill has the advantage that some computers switch > off the bluetooth LED. Which does not happen (at least on my Thinkpad) if > it's just powered off (as kde does at the moment). > > rfkill can also detect if bluetooth has been deactivated by a hardware switch. > > btw. please mark https://gitorious.org/libbluedevil/libbluedevil as obsolete > and update http://projects.ufocoders.com/projects/libbluedevil/wiki. I used > the old gitorious code base at first. > > > Diffs > ----- > > bluedevil/bluedevilmanager.h 0386b8e > bluedevil/bluedevilmanager.cpp 594d3bd > bluedevil/test/bluedeviltest.cpp 2d3d0e2 > > Diff: https://git.reviewboard.kde.org/r/102983/diff/ > > > Testing > ------- > > I added a test to bluedeviltest and it works for me. > > > Thanks, > > Rüdiger Sonderfeld > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
