-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123828/
-----------------------------------------------------------
(Updated July 12, 2015, 1:19 p.m.)
Review request for Plasma, David Edmundson, Martin Gräßlin, and Michael Jansen.
Changes
-------
Add plasma group as reviewer, hope to get more eyes on it that way... This is
really quite a bad bug.
Bugs: 343665
https://bugs.kde.org/show_bug.cgi?id=343665
Repository: plasma-desktop
Description
-------
The KShortcutsEditor reads the property "defaultShortcuts" from the assigned
QAction. Fill it in with default "hardcoded" shortcuts. Appending the defaults
to the list of active shortcuts just creates shortcut lists that grow longer
and longer every time user saves settings in this KCM.
Still does not have a solution for upgrade of existing users' configuration. If
the user has a messed up "kdeglobals" file now, after installing upgrade with
this fix user will have to open up this KCM and hit "Defaults" button to reset
settings. After that things should work ok. I don't have any idea for solution
of automatically correcting broken config file after upgrade.
Diffs
-----
kcms/standard_actions/standard_actions_module.cpp d1c4ad3
Diff: https://git.reviewboard.kde.org/r/123828/diff/
Testing
-------
Basic testing to see how the config file "kdeglobals" look after saving some
changed shortcuts, looks correct to me. Now only the shortcuts that are not
default are saved, and they are saved correctly (verified that by closing kcm,
opening it again and saw that my settings were still intact).
Thanks,
Simon Persson
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
