----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review82804 -----------------------------------------------------------
Ship it! Ship It already! src/declarativeimports/calendar/qml/DaysCalendar.qml (lines 36 - 37) <https://git.reviewboard.kde.org/r/122488/#comment57128> This is unused src/declarativeimports/calendar/qml/DaysCalendar.qml (line 49) <https://git.reviewboard.kde.org/r/122488/#comment57127> I find this name confusing. Could you make the name more precise like eg. dateMatchingPrecision and this looks like a perfect candidate for an enum ;) src/declarativeimports/calendar/qml/DaysCalendar.qml (lines 56 - 57) <https://git.reviewboard.kde.org/r/122488/#comment57125> Can you put the comments back here from MonthView.qml please src/declarativeimports/calendar/qml/MonthView.qml (line 115) <https://git.reviewboard.kde.org/r/122488/#comment57126> The cells seems to be large enough to go with Locale.LongFormat ...the short format is rarely (if at all) used in Czech, eg. I imagine it might be the same for other langs. src/declarativeimports/calendar/qml/MonthView.qml (line 192) <https://git.reviewboard.kde.org/r/122488/#comment57130> This should maybe be i18nc as well? src/declarativeimports/calendar/qml/MonthView.qml (line 249) <https://git.reviewboard.kde.org/r/122488/#comment57129> This should be i18nc (cause, you know, RTL and stuff) - Martin Klapetek On July 18, 2015, 10:28 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122488/ > ----------------------------------------------------------- > > (Updated July 18, 2015, 10:28 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-framework > > > Description > ------- > > This improves the calendar navigation by providing a "Year overview" showing > all 12 months in a grid, and a "Decade overview" showing the current decade > in a grid. > > A lot of code has just been moved around. The overviews use a QML ListModel > owing to laziness. > > See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that > mouse click effect!) > > > Diffs > ----- > > src/declarativeimports/calendar/calendar.h 5dc3081 > src/declarativeimports/calendar/calendar.cpp c462dbd > src/declarativeimports/calendar/daydata.h 39ac086 > src/declarativeimports/calendar/daysmodel.h e1285f6 > src/declarativeimports/calendar/daysmodel.cpp 1a6f454 > src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e > src/declarativeimports/calendar/qml/DaysCalendar.qml ab3e750 > src/declarativeimports/calendar/qml/MonthView.qml 601755f > > Diff: https://git.reviewboard.kde.org/r/122488/diff/ > > > Testing > ------- > > I changed the selection to be persistent during navigation; other than that, > should work as before, with the new overviews. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
