> On July 24, 2015, 3:42 p.m., Kai Uwe Broulik wrote: > > I'm fine with the pipe in general but just using a | might look really > > strange depending on the font. A separate Rectangle would be better imho > > Martin Klapetek wrote: > Good point, I'll see how that works. > > (for those not knowing, Rectangle can also serve as just a straight line) > > Martin Klapetek wrote: > It doesn't work very well. The Flow apparently cannot vertically center > things > and so this happens - http://paste.opensuse.org/view/raw/89713887 > > I could set the height to the Label height, but then it goes across the > whole > panel and just looks weird. So I think I'll go back to pipe. > > Kai Uwe Broulik wrote: > And what about wrapping the Rectangle inside an Item? Then you can set > the height to whatever you like (dunno contentHeight/paintedHeight of one of > the labels) \o/
Yeah I did thought about that, that would of course work; originally I wanted to spare that extra cpu/ram for that one extra object, but oh well. It makes things nice *shrug* - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124449/#review82891 ----------------------------------------------------------- On July 24, 2015, 12:27 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124449/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 12:27 p.m.) > > > Review request for Plasma and KDE Usability. > > > Bugs: 348072 > https://bugs.kde.org/show_bug.cgi?id=348072 > > > Repository: plasma-workspace > > > Description > ------- > > One of the most reported bugs wrt digital clock is that the second line > text (date or timezone) is unreadable on small panels so this adds new > state to the clock applet that lays things horizontally when the panel > is too small to show text with the "small" font (set in system settings). > > When there is a date displayed, a delimiter is put in between to allow > easier and faster spotting the time (as on a first glance there is just > a bunch of numbers, so quickly orienteering is super important). I used > the dot symbol first but then went for pipe which I think looks more clean; > see screenshots for comparison. > > I've made a quick video showing the state changes, > see https://www.youtube.com/watch?v=t7w0k8H22h4 - it shows the bullet > delimiter and a bit wrong spacing which is now fixed. > > > Diffs > ----- > > applets/digital-clock/package/contents/ui/DigitalClock.qml 9506078 > > Diff: https://git.reviewboard.kde.org/r/124449/diff/ > > > Testing > ------- > > Everything works as it used and now with small panel things are layed > horizontally, see video above. > > > File Attachments > ---------------- > > Delimiters > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/24/e0aa0799-ca56-4bdb-b4e6-b8db6622ff10__clock-delimiters.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel