> On Aug. 1, 2015, 12:11 vorm., David Edmundson wrote: > > lookandfeel/contents/loginmanager/Main.qml, line 187 > > <https://git.reviewboard.kde.org/r/124509/diff/2/?file=388547#file388547line187> > > > > I can see why you did this, but if we're having to hack round our own > > features then we clearly have a problem.
Probably ToolButton needs a "round" property where you can tell it not to become round > On Aug. 1, 2015, 12:11 vorm., David Edmundson wrote: > > lookandfeel/contents/loginmanager/Main.qml, line 209 > > <https://git.reviewboard.kde.org/r/124509/diff/2/?file=388547#file388547line209> > > > > this seems a bit odd; should we just use a context menu? > > > > I think we can use the menu property on the button and put the model > > items as entries in a Repeater I didn't know that. I wanted to use the QQC Menu because it supports exclusiveGroup but I couldn't pop it up at an arbitrary position, so with "menu" should work. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124509/#review83144 ----------------------------------------------------------- On Juli 29, 2015, 10:58 vorm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124509/ > ----------------------------------------------------------- > > (Updated Juli 29, 2015, 10:58 vorm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > ------- > > As discussed with the VDG since it's a more of a power user feature > > > Diffs > ----- > > lookandfeel/contents/loginmanager/Main.qml 065a115 > > Diff: https://git.reviewboard.kde.org/r/124509/diff/ > > > Testing > ------- > > Work, I had to employ a hack to make the button stay square, and also > ComboBox doesn't have a public API to open the popup. I tried using Plasma > Menu but it doesn't support exclusive group and the QQC Menu cannot be told > where it should open other than the mouse position (also why is the text > field not the same height as the login button?) > > > File Attachments > ---------------- > > Login screen > > https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
