----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124580/#review83314 -----------------------------------------------------------
Ship it! Ship It! - Bhushan Shah On Aug. 1, 2015, 11:57 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124580/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2015, 11:57 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > For some reason we have two IconDialog's exported to QML. > > One in KDeclarative, one in Plasma-Frameworks/platformcomponents. > > The one in plasmacomponents performs an exec() in the main thread from > QML which is a very bad idea. the one in kdeclarative is good. > > BUG: 350864 > > > Diffs > ----- > > desktoppackage/contents/activitymanager/ActivityCreationDialog.qml > 102926bf57f21f33e2c45ff160ddfc68dd028dde > > Diff: https://git.reviewboard.kde.org/r/124580/diff/ > > > Testing > ------- > > Changed my activity icon. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel